A lot of table improvements #420
Conversation
| ui.weak("(auto)").on_hover_text( | ||
| "Color chosen automatically, since it was not logged.", | ||
| ); |
There was a problem hiding this comment.
🚢 so much better!!
scrollbars height made me stop for a bit, but yeah makes sense - we want the outer selection panel scrollbar only if the "number of elements including tables" gets too big (or your screen too small). How does this behave with on-hover though which uses the same table? 🤔
|
|
||
| egui_extras::TableBuilder::new(ui) | ||
| TableBuilder::new(ui) |
There was a problem hiding this comment.
might apply to others but I got it to be tricked into displaying neither horiztonal nor vertical scrollbars when it should have some. To repro open the text_logging example and resize the window a bit until the top log frame (3rd_party_logs) doesn't get enough space anymore
(they are still there and mouse wheel(s) work)
There was a problem hiding this comment.
Good repro. Got me this:
Not ideal
There was a problem hiding this comment.
I guess I'm stuck in this Table-shaped hell for a while longer
There was a problem hiding this comment.
partially confirmed! Right scroll bar shows up only if I scroll all the way to the right which isn't optimal imho
There was a problem hiding this comment.
Fix nr2 coming in emilk/egui#2371
|
Bonus: I made the tables in the Text Space Views expand to use up all available space, thus moving the horizontal scroll to the bottom:
|
Closes #341
Closes a lot of #370
Based on emilk/egui#2369
This gives most tables auto-sized columns, and lets us double-click columns-separators to reset the column sizes.
It improves the
scroll-to-timebehavior of the text log.I also took a pass over all
Tableuses and just generally improved it.Screenshots
Nice default columns widths:
Nicer looking annotation context:
Nicer annotation context tables:
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)