-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ Doxygen documentation & many doc improvements #4191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort members, warn as error, skip cpp & h files
… document namespaces
…stripping from source files
Wumpf
added
📖 documentation
Improvements or additions to documentation
🌊 C++ API
C/C++ API specific
include in changelog
labels
Nov 9, 2023
teh-cmc
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm good catch. I'll look into this after landing! |
Closed
Wumpf
added a commit
that referenced
this pull request
Nov 13, 2023
### What * Almost fixe_s #3974 * Follow-up of #4191 A few remaining items & polish for the C++ docs. Now uploaded to gh-pages as well on push to main (🤞 it works.......) Commit by commit! ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4212) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4212) - [Docs preview](https://rerun.io/preview/4d098307e728ccea06f408df01f700dda18739c1/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/4d098307e728ccea06f408df01f700dda18739c1/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🌊 C++ API
C/C++ API specific
📖 documentation
Improvements or additions to documentation
include in changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Try it yourself:
https://wumpf.github.io/rerun-cpp-doc-test/
(yes I sacrificed a repo for this ;))
Or to get a perfect up to date version now and in the future just run
pixi run cpp-docs
, the docs appear then inrerun_cpp/docs/html/index.html
After some back and forth I landed with a pure doxygen documentation using the impressively good https://jothepro.github.io/doxygen-awesome-css/ css.
To avoid submoduling and make customization easy, the theme is embedded in our repo.
Otherwise tons of improvements on our doc strings. Started a guide on how to write docs similar to what we have for python.
Quite happy with it as-is already. Some of the doc improvements to be done are also related to smaller code refactors I want to do :)
Review tip: The first commit contains the default doxygen file, if you want to know what I changed about it just exclude it.
Bunch of screenshots for the lazy:
Checklist