-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce rerun_c library size (by depending on fewer unnecessary crates) #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
enhancement
New feature or request
🌊 C++ API
C/C++ API specific
include in changelog
labels
Nov 6, 2023
Wumpf
force-pushed
the
andreas/cpp/smaller_rerun_c
branch
from
November 6, 2023 15:19
4f9e827
to
7ce3939
Compare
Wumpf
force-pushed
the
andreas/cpp/smaller_rerun_c
branch
from
November 6, 2023 16:50
63ba5f2
to
a68bba4
Compare
jleibs
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This seems logical to me and paves an improved path for standalone packages for adding new types without cluttering the sdk/rerun_c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
re_log_types
no longer depends onre_types
re_sdk
no longer depends onre_memory
re_sdk
no longer depends onre_types
rerun
crateDependency graph before:
Dependency graph now:
Graphs via:
cargo depgraph --all-deps --workspace-only --all-features --dedup-transitive-deps | dot -Tpng > deps.png
Rerun C checks via:
cargo build -p rerun_c --release && ls -l target/release/librerun_c.a
Checklist