Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of cmake log from building & downloading libArrow #4103

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 31, 2023

What

Before: unspeakable amount of log
Now: (windows):

  1>Creating directories for 'arrow_cpp'
  Performing download step (git clone) for 'arrow_cpp'
  Cloning into 'arrow_cpp'...
  HEAD is now at a6eabc2b MINOR: [Release] Update versions for 10.0.1
  Submodule 'cpp/submodules/parquet-testing' (https://github.com/apache/parquet-testing.git) registered for path 'cpp/submodules/parquet-testing'
  Submodule 'testing' (https://github.com/apache/arrow-testing) registered for path 'testing'
  Cloning into 'C:/dev/rerun-io/rerun/build/arrow/src/arrow_cpp/cpp/submodules/parquet-testing'...
  Cloning into 'C:/dev/rerun-io/rerun/build/arrow/src/arrow_cpp/testing'...
  Submodule path 'cpp/submodules/parquet-testing': checked out 'e13af117de7c4f0a4d9908ae3827b3ab119868f3'
  Submodule path 'testing': checked out '00c483283433b4c02cb811f260dbe35414c806a4'
  Building Custom Rule C:/dev/rerun-io/rerun/rerun_cpp/CMakeLists.txt
  Performing update step for 'arrow_cpp'
  No patch step for 'arrow_cpp'
  Performing configure step for 'arrow_cpp'
  -- arrow_cpp configure command succeeded.  See also C:/dev/rerun-io/rerun/build/arrow/src/arrow_cpp-stamp/arrow_cpp-configure-*.log
  Performing build step for 'arrow_cpp'
  -- arrow_cpp build command succeeded.  See also C:/dev/rerun-io/rerun/build/arrow/src/arrow_cpp-stamp/arrow_cpp-build-*.log
  Performing install step for 'arrow_cpp'
  -- arrow_cpp install command succeeded.  See also C:/dev/rerun-io/rerun/build/arrow/src/arrow_cpp-stamp/arrow_cpp-install-*.log
  Completed 'arrow_cpp'

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 😤 annoying Something in the UI / SDK is annoying to use 🌊 C++ API C/C++ API specific include in changelog labels Oct 31, 2023
@Wumpf Wumpf added this to the 0.10.1 milestone Oct 31, 2023
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - this is a big improvement

rerun_cpp/CMakeLists.txt Outdated Show resolved Hide resolved
rerun_cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit ef18d7b into main Nov 1, 2023
34 checks passed
@Wumpf Wumpf deleted the andreas/cpp/less-arrow-log-spam branch November 1, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🌊 C++ API C/C++ API specific include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants