Avoid possible link/symbol errors but defaulting all OSes to static linking of arrow #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to make sure that we compile with |
emilk
approved these changes
Oct 31, 2023
Wumpf
approved these changes
Oct 31, 2023
| @@ -40,19 +50,17 @@ function(set_default_warning_settings target) | |||
| endif() | |||
|
|
|||
| if(CMAKE_BUILD_TYPE STREQUAL "Debug") | |||
| # Debug build with fsanatize: | |||
| target_compile_options(${target} PRIVATE -g -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fno-optimize-sibling-calls) | |||
There was a problem hiding this comment.
I'm not sure, but I think those were added specifically because they are required for ASAN? Not sure. But why would we otherwise remove these optimizations?
There was a problem hiding this comment.
No, these are there to improve stack-traces in general. I'll add a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Shared libraries have some sharp corners, especially when the libraries may be available as system libraries, which take precedence.
Note for testing:
Because this only changes the default if you have an existing build folder, this will do nothing. The default will have been cached as a persisted configuration option. To test locally either purge your build folder or manually invoke cmake with
-DRERUN_ARROW_LINK_SHARED=offAfter running
just cpp-test, confirm thatldd build/rerun_cpp/tests/rerun_sdk_testsdoes not includearrowChecklist
Test
Linux (CI)