Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve C++ SDK perf 5x by respecting CMAKE_BUILD_TYPE and enabling mimalloc #4094

Merged
merged 12 commits into from
Oct 31, 2023
Merged

Improve C++ SDK perf 5x by respecting CMAKE_BUILD_TYPE and enabling mimalloc #4094

Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8e51145
Pass through CMAKE_BUILD_TYPE to arrow build
jleibs Oct 30, 2023
ff1d386
Sort
jleibs Oct 30, 2023
4166ef9
Enable mimalloc
jleibs Oct 30, 2023
2af8f9d
Default arrow to release if no build-type is otherwise specified
jleibs Oct 30, 2023
c68cfbf
Merge branch 'main' into jleibs/arrow_match_build_flags
jleibs Oct 31, 2023
d80eeb8
Fix windows issues and use arrow cmake prefix files instead of CMAKE_…
Wumpf Oct 31, 2023
28ff7b0
fix windows warning
Wumpf Oct 31, 2023
1504b38
fix CRLF
Wumpf Oct 31, 2023
c441936
fix definitely not helpful link on cmakelists comment
Wumpf Oct 31, 2023
d0d05b9
Merge branch 'main' into jleibs/arrow_match_build_flags
jleibs Oct 31, 2023
87c0346
Use static bundled dependencies on all platforms
jleibs Oct 31, 2023
73f9733
Fix clean build
jleibs Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions rerun_cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,12 @@ if(RERUN_DOWNLOAD_AND_BUILD_ARROW)
set(DARROW_CXXFLAGS "")
endif()

if(NOT CMAKE_BUILD_TYPE)
set(ARROW_CMAKE_BUILD_TYPE Release)
else()
set(ARROW_CMAKE_BUILD_TYPE ${CMAKE_BUILD_TYPE})
endif()

ExternalProject_Add(
arrow_cpp
PREFIX ${ARROW_DOWNLOAD_PATH}
Expand All @@ -168,18 +174,20 @@ if(RERUN_DOWNLOAD_AND_BUILD_ARROW)
GIT_PROGRESS true
CMAKE_ARGS
--preset ninja-debug-minimal
-DARROW_IPC=ON
-DARROW_BOOST_USE_SHARED=OFF
-DARROW_BUILD_SHARED=${ARROW_BUILD_SHARED}
-DARROW_BUILD_STATIC=${ARROW_BUILD_STATIC}
-DCMAKE_INSTALL_PREFIX=${ARROW_DOWNLOAD_PATH}
-DARROW_CXXFLAGS=${DARROW_CXXFLAGS}
-DARROW_IPC=ON
-DARROW_JEMALLOC=OFF
-DARROW_MIMALLOC=ON
emilk marked this conversation as resolved.
Show resolved Hide resolved
-DARROW_USE_ASAN=OFF
-DARROW_USE_TSAN=OFF
-DARROW_USE_UBSAN=OFF
-DARROW_JEMALLOC=OFF
-Dxsimd_SOURCE=BUNDLED
-DBOOST_SOURCE=BUNDLED
-DARROW_BOOST_USE_SHARED=OFF
-DARROW_CXXFLAGS=${DARROW_CXXFLAGS}
-DCMAKE_BUILD_TYPE=${ARROW_CMAKE_BUILD_TYPE}
-DCMAKE_INSTALL_PREFIX=${ARROW_DOWNLOAD_PATH}
-Dxsimd_SOURCE=BUNDLED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should sort these defines if their order doesn't matter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR sorts them.

SOURCE_SUBDIR cpp
BUILD_BYPRODUCTS ${ARROW_LIBRARY_FILE}
)
Expand Down
Loading