Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecordingStream: introduce connect_opts #4042

Merged
merged 5 commits into from
Oct 27, 2023
Merged

RecordingStream: introduce connect_opts #4042

merged 5 commits into from
Oct 27, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 27, 2023 •
edited
Loading

Promised follow up after the addition of spawn_opts.

This simplifies a bunch of things and greatly improve DX while we wait for Rust to unlock the default parameter skill ✨

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🦀 Rust API Rust logging API 🧑‍💻 dev experience developer experience (excluding CI) include in changelog labels Oct 27, 2023
emilk
emilk approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet ❤️

@teh-cmc teh-cmc merged commit 07b9701 into main Oct 27, 2023
34 of 35 checks passed
@teh-cmc teh-cmc deleted the cmc/connect_opts branch October 27, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI) include in changelog 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @emilk