Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grayscale images being too dark #3999

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 25, 2023

What

We previously would apply a grayscale colormap to a grayscale image - this was not only a bit redundant; it actually caused the wrong colors. Now we only apply the grayscale color map for things like depth images and tensors (when the user has selected such a colormap) and in all other cases we preserve the raw grayscale values as best we can.

We tested:

  • grayscale images of different bit depth and ranges (see below)
  • tensor selection colormap preview
  • tensor with grayscale colormap
  • depth point cloud selection colormap preview
  • depth point cloud with grayscale colormap
  • NV12 test

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself include in changelog labels Oct 25, 2023
@Wumpf Wumpf self-requested a review October 25, 2023 09:24
@Wumpf Wumpf added this to the 0.10 C++ milestone Oct 25, 2023
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
once and for all!

@emilk emilk merged commit c021850 into main Oct 25, 2023
34 of 41 checks passed
@emilk emilk deleted the emilk/fix-grayscale-images-again branch October 25, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grayscale image presented too dark
2 participants