Fix grayscale images being too dark #3999
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We previously would apply a grayscale colormap to a grayscale image - this was not only a bit redundant; it actually caused the wrong colors. Now we only apply the grayscale color map for things like depth images and tensors (when the user has selected such a colormap) and in all other cases we preserve the raw grayscale values as best we can.
We tested:
Checklist