-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to generate RRD vs. screenshots comparisons #3946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than copying all of the index business it seems like this could potentially be simplified by using a iframe pointed at app.rerun.io.
Yeah I took all possible shortcuts here. I've copied what |
Agree with @jleibs, copying all the index stuff is a bit too much.
Not sure what you mean by "from the local server" -- the web app can load rrd files from the local disk, can't it?
We generate a hosted app.rerun.io for each PR commit ( |
The remaining disk size is primarily explained by the demo examples' RRD (50-70MiB each).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works for me. Thanks for cleaning up to avoid the duplication:
The only confusion is when it runs the log messages:
Serving examples at http://127.0.0.1:8080/
Press enter to reload static files
[2023-10-23T15:42:49Z INFO re_ws_comms::server] Listening for WebSocket traffic on ws://localhost:9877. Connect with a Rerun Web Viewer.
[2023-10-23T15:42:49Z INFO re_web_viewer_server] Started web server on http://localhost:9090
[2023-10-23T15:42:49Z INFO re_sdk::web_viewer] Web server is running - view it at http://localhost:9090?url=ws://localhost:9877
Make it a bit confusing to know which url to use.
Co-authored-by: Jeremy Leibs <[email protected]>
Indeed. I've changed it to use a sub-process and silence the warning via the environment variables. |
### What Updated a bunch of example and/or screenshot based on discrepancies identified with #3946. In the process, several examples were brought to their previous state (higher resolution, etc.), including depth image, etc. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] ~~I've included a screenshot or gif (if applicable)~~ * [x] ~~I have tested [demo.rerun.io](https://demo.rerun.io/pr/3954) (if applicable)~~ * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/3954) - [Docs preview](https://rerun.io/preview/842a10be1377e241915731431235d64f5e8624c5/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/842a10be1377e241915731431235d64f5e8624c5/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
What
This PR introduces a script that builds a local, web-based comparison between our various example code and the screenshot we provide along them, to help identify discrepancies.
Checklist
I have tested demo.rerun.io (if applicable)