Fix crash when using RecordingStream::set_thread_local on macOS
#3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an ugly workaround for the crash in #2889
…but disable it for Mac for now
emilk
added
💣 crash
Wumpf
approved these changes
Oct 19, 2023
| re_log::warn!("Using thread-local RecordingStream on macOS can result in data loss because of https://github.com/rerun-io/rerun/issues/2889"); | ||
|
|
||
| // Give the batchet and sink threads a chance to process the data. | ||
| std::thread::sleep(std::time::Duration::from_millis(500)); |
There was a problem hiding this comment.
Tbh not sure if we already talked about this, but there's no way easy way right now to know whether the threads are still busy, right? Would be nice to be able to tell them to join instead 🤔
Adding 500ms to our shutdown time is pretty awful and error prone.
There was a problem hiding this comment.
Yeah, it's not great, but we would need to check if all the queues are empty and the threads non-busy all the way down, and it is not trivial
There was a problem hiding this comment.
I'll open a new issue (and close the old one) as a future TODO
Co-authored-by: Andreas Reich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
cargo test -p re_sdk --lib fallbackscrashes on aarch64 Mac #3558RecordingStreamon Mac and WIndows #3937Checklist