Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if no resolution provided to Pinhole #3923

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Warn if no resolution provided to Pinhole #3923

merged 5 commits into from
Oct 20, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 18, 2023 •
edited by github-actions bot
Loading

What

Resolves:

Removes the setting of a default resolution if not provided and generates warnings/exceptions as appropriate.

Also uses the TensorData to derived a resolution if none was provided when rendering the pinhole frustum.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs marked this pull request as ready for review October 18, 2023 19:50
@jleibs jleibs added the 🐍 Python API Python logging API label Oct 18, 2023
@jleibs jleibs merged commit 851e059 into main Oct 20, 2023
32 checks passed
@jleibs jleibs deleted the jleibs/no_default_resolution branch October 20, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleibs @emilk