Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ fix failure to serialize empty component arrays / archetypes #3919

Merged
merged 4 commits into from
Oct 18, 2023
Merged

C++ fix failure to serialize empty component arrays / archetypes #3919

merged 4 commits into from
Oct 18, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 18, 2023 •
edited by github-actions bot
Loading

What

The actual fix is isolated to the second commit (c34e168).

The first makes serialization code nicer and it's what's left of my attempt to solve it on the C++ side which I gave upon eventually (but it was very obviously worth keeping)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🪳 bug Something isn't working 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 18, 2023
teh-cmc
teh-cmc requested changes Oct 18, 2023
View reviewed changes
crates/rerun_c/src/lib.rs Outdated Show resolved Hide resolved
@teh-cmc teh-cmc self-requested a review October 18, 2023 17:43
teh-cmc
teh-cmc reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Wumpf Wumpf merged commit 610ebda into main Oct 18, 2023
32 checks passed
@Wumpf Wumpf deleted the andreas/cpp/fix-empty-vector-failure branch October 18, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++ arrow failure when logging empty vector
2 participants
@Wumpf @teh-cmc