Improve taplo output on failure
#3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
🧑💻 dev experience
emilk
approved these changes
Oct 18, 2023
| @@ -277,7 +277,7 @@ jobs: | |||
|
|
|||
| - name: Taplo check | |||
| run: | | |||
| taplo fmt --check | |||
| taplo fmt --check --diff | |||
There was a problem hiding this comment.
out of the scope of this PR, but we should call just functions in the .yml files instead of duplicating code imho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When taplo fails on CI or with
just toml-lint, it tells us very little about what is wrong. The PR adds the--diffoption so we can directly see the fix that needs to be done.Checklist