Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make codegen I/O-free and agnostic to output location #3888

Merged
merged 12 commits into from
Oct 17, 2023
Merged

Make codegen I/O-free and agnostic to output location #3888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
61c889a
codegen: clean up rust's generate_folder and make it crate-agnostic
teh-cmc Oct 16, 2023
37cb5f3
new I/O-free CodeGenerator trait
teh-cmc Oct 17, 2023
8f67e73
make gitattributes generation i/o-free and agnostic to output location
teh-cmc Oct 17, 2023
a981be9
make orphan tracking agnostic to output location
teh-cmc Oct 17, 2023
f2c7f01
i/o-free, location agnostic rust codegen
teh-cmc Oct 17, 2023
8e7027f
i/o-free cpp codegen
teh-cmc Oct 17, 2023
8bd8de9
i/o-free docs codegen
teh-cmc Oct 17, 2023
c4c25d5
i/o-free python codegen
teh-cmc Oct 17, 2023
1836a11
lint
teh-cmc Oct 17, 2023
cc4bb19
dont run clang-format on gitattributes
teh-cmc Oct 17, 2023
2e98955
that should be a 'continue'
teh-cmc Oct 17, 2023
136f851
pr comments
teh-cmc Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 0 additions & 133 deletions crates/re_types/.gitattributes
View file
Open in desktop

This file was deleted.

27 changes: 27 additions & 0 deletions crates/re_types/src/archetypes/.gitattributes
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions crates/re_types/src/blueprint/.gitattributes
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions crates/re_types/src/components/.gitattributes
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 34 additions & 0 deletions crates/re_types/src/datatypes/.gitattributes
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions crates/re_types/src/testing/archetypes/.gitattributes
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/re_types/src/testing/blueprint/mod.rs
View file
Open in desktop

This file was deleted.

25 changes: 25 additions & 0 deletions crates/re_types/src/testing/components/.gitattributes
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions crates/re_types/src/testing/datatypes/.gitattributes
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions crates/re_types_builder/src/bin/build_re_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const DEFINITIONS_DIR_PATH: &str = "crates/re_types/definitions";
const ENTRYPOINT_PATH: &str = "crates/re_types/definitions/rerun/archetypes.fbs";
const DOC_EXAMPLES_DIR_PATH: &str = "docs/code-examples";
const CPP_OUTPUT_DIR_PATH: &str = "rerun_cpp";
const RUST_OUTPUT_DIR_PATH: &str = "crates/re_types/.";
const PYTHON_OUTPUT_DIR_PATH: &str = "rerun_py/rerun_sdk/rerun";
const PYTHON_TESTING_OUTPUT_DIR_PATH: &str = "rerun_py/tests/test_types";
const DOCS_CONTENT_DIR_PATH: &str = "docs/content/reference/types";
Expand Down Expand Up @@ -72,7 +71,6 @@ fn main() {
let definitions_dir_path = workspace_dir.join(DEFINITIONS_DIR_PATH);
let entrypoint_path = workspace_dir.join(ENTRYPOINT_PATH);
let cpp_output_dir_path = workspace_dir.join(CPP_OUTPUT_DIR_PATH);
let rust_output_dir_path = workspace_dir.join(RUST_OUTPUT_DIR_PATH);
let python_output_dir_path = workspace_dir.join(PYTHON_OUTPUT_DIR_PATH);
let python_testing_output_dir_path = workspace_dir.join(PYTHON_TESTING_OUTPUT_DIR_PATH);
let docs_content_dir_path = workspace_dir.join(DOCS_CONTENT_DIR_PATH);
Expand Down Expand Up @@ -120,7 +118,7 @@ fn main() {
),
|| re_types_builder::generate_rust_code(
&reporter,
rust_output_dir_path,
workspace_dir,
&objects,
&arrow_registry
),
Expand Down
Loading
Loading