Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jpeg returning None for image_height_width_channels #3885

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix jpeg returning None for image_height_width_channels #3885

merged 1 commit into from
Oct 17, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 17, 2023 •
edited
Loading

What

Small mistake (maybe merge error) that slipped into #3541

before:
image

After:
image
(actually curious it says depth 4 here; that must be a bug on the logging side though. Same behavior as before!)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 17, 2023
@Wumpf Wumpf merged commit 59fbbb8 into main Oct 17, 2023
35 of 37 checks passed
@Wumpf Wumpf deleted the andreas/fix-jpeg-no-longer-displayed branch October 17, 2023 09:12
@Wumpf Wumpf mentioned this pull request Oct 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @teh-cmc