Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve comments from #3822 #3836

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Improve comments from #3822 #3836

merged 5 commits into from
Oct 12, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 12, 2023 •
edited by github-actions bot
Loading

What

Address some PR concerns from:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs added 📺 re_viewer affects re_viewer itself exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 12, 2023
@jleibs jleibs marked this pull request as ready for review October 12, 2023 11:19
@jleibs jleibs requested a review from emilk October 12, 2023 11:19
@jleibs jleibs mentioned this pull request Oct 12, 2023
Merged
4 tasks
@Wumpf Wumpf merged commit 2f23c52 into main Oct 12, 2023
30 checks passed
@Wumpf Wumpf deleted the jleibs/heuristic_filter_comments branch October 12, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jleibs @emilk @Wumpf