Refactor our build.rs files
#3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🚜 refactor
emilk
force-pushed
the
emilk/refactor-build-rs
branch
from
19433b4 to
68a6dac
Compare
teh-cmc
approved these changes
Oct 11, 2023
crates/re_build_tools/src/lib.rs
Outdated
| @@ -57,6 +57,13 @@ pub(crate) fn should_output_cargo_build_instructions() -> bool { | |||
| OUTPUT_CARGO_BUILD_INSTRUCTIONS.load(Ordering::Relaxed) | |||
| } | |||
|
|
|||
| /// Are we running inside the workspace of <https://github.com/rerun-io/rerun> ? | |||
| /// | |||
| /// Otherwise we might be running on users machines. | |||
There was a problem hiding this comment.
That's an oddly formulated comment 🤔 Running inside the workspace and running on users machines are not antithetical
There was a problem hiding this comment.
yeah, good catch - I'll improve the naming and documentation
There was a problem hiding this comment.
I want to communicate "Rerun user"
crates/re_build_tools/src/lib.rs
Outdated
Comment on lines
70
to
73
| /// We are likely running on a users machine. | ||
| /// | ||
| /// Try to do as little work as possible. | ||
| ProbablyUserMachine, |
There was a problem hiding this comment.
Again, that whole notion of "user machine" is confusing.
I guess this means "OutOfWorkspace" or smth, which is what I would call it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This cleans up all our
build.rsfiles by introducing better helpers inre_build_tools. No functionality is actually changed (except a few tiny improvements).This will make it easier to take take the next steps of opting-in to most of these features.
This is just the first step.
Checklist