Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when loading huge image #3775

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Fix crash when loading huge image #3775

merged 3 commits into from
Oct 10, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 10, 2023

What

Test code:

import numpy as np
import rerun as rr

rr.init("rerun_example_huge_image", spawn=True)

image = np.zeros((80, 120_000, 3), dtype=np.uint8)
image[:, :, 0] = 255
image[0:40, 0:60_000] = (0, 255, 0)
rr.log("huge_image", rr.Image(image))

Output:

[2023-10-10T11:25:43Z ERROR re_space_view_spatial::parts::images] Failed to create texture for "huge_image": Texture was 120000x80, larger that the max of 16384

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 🔺 re_renderer affects re_renderer itself 💣 crash crash, deadlock/freeze, do-no-start include in changelog labels Oct 10, 2023
Co-authored-by: Clement Rey <[email protected]>
@emilk emilk merged commit f773c38 into main Oct 10, 2023
15 of 22 checks passed
@emilk emilk deleted the emilk/fix-texture-crash branch October 10, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 crash crash, deadlock/freeze, do-no-start include in changelog 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants