Fix performance regression when viewing images and tensors #3767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When hovering images the
InstanceKey
corresponds to the hovered pixel value (tensors are mono-components; their elements are their instances). We accidentally were using this instance key as the key for several of our caches, which means we would get constant cache misses when hovering an image, leading to huge performance degradation.This PR switches to using
RowId
as the primary key for tensors. In particular, it is the row id of theTensorData
component, so I call ittensor_data_row_id
everywhere for consistency and clarity. There can never be more than onTensorData
per row, and each row has a uniqueRowId
, so this works well.This simplifies a lot of the code too, removing most uses of
VersionedInstancePath
andVersionedInstancePathHash
.Checklist