Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type of entity_path!() and entity_path_vec!() on empty input. #3734

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix return type of entity_path!() and entity_path_vec!() on empty input. #3734

merged 1 commit into from
Oct 9, 2023

Conversation

kpreid
Copy link
Collaborator

@kpreid kpreid commented Oct 9, 2023 •
edited
Loading

What

Previously,

  • entity_path!() would return a Vec instead of an EntityPath.
  • entity_path_vec!() would return a Vec of unknown element type.

Now entity_path_vec! always returns a typed vector and entity_path!
makes use of entity_path_vec!.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@kpreid
Fix output of entity path macros for empty input.
2c7e66c 
* `entity_path!()` would return a `Vec` instead of an `EntityPath`.
* `entity_path_parts!()` would return a `Vec` of unknown element type.

Now `entity_path_parts!` always returns a typed vector and `entity_path!`
makes use of `entity_path_parts!`.
Wumpf
Wumpf approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! Thanks for adding a short unit test on top <3

@Wumpf Wumpf added 🪳 bug Something isn't working 🦀 Rust API Rust logging API include in changelog labels Oct 9, 2023
@Wumpf Wumpf added this to the 0.9.1 milestone Oct 9, 2023
@Wumpf Wumpf merged commit 0a4a30b into rerun-io:main Oct 9, 2023
30 of 32 checks passed
@kpreid kpreid deleted the path branch December 31, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working include in changelog 🦀 Rust API Rust logging API
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kpreid @Wumpf