Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to 127.0.0.1 when checking for existing viewer #3696

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 5, 2023

What

0.0.0.0 isn't valid on some hosts.

Checklist

@jleibs jleibs added 🪳 bug Something isn't working 🐍 Python API Python logging API exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 5, 2023
@jleibs jleibs marked this pull request as ready for review October 5, 2023 14:37
@emilk
Copy link
Member

emilk commented Oct 5, 2023

Fix for #3501

@emilk emilk merged commit 5285fd3 into main Oct 5, 2023
26 of 29 checks passed
@emilk emilk deleted the jleibs/connect_localhost branch October 5, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants