Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add obj mesh support to viewer #3670

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Add obj mesh support to viewer #3670

merged 2 commits into from
Oct 4, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 4, 2023

What

More like "enable". Works fine, but naturally doesn't support mtl files yet.

⚠️ Let's have a look on the Wasm size tracking for this one before merge ⚠️

Tested using the checked in blender exported obj file https://github.com/rerun-io/rerun/blob/main/crates/re_renderer/examples/rerun.obj.zip, unpacked and then python ./docs/code-examples/asset3d_simple.py crates/re_renderer/examples/rerun.obj
image

Checklist

@Wumpf Wumpf added enhancement New feature or request 📺 re_viewer affects re_viewer itself include in changelog labels Oct 4, 2023
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there some docs needing updating too, or were they correct?

And yes, good call on checking wasm size before merge

@Wumpf
Copy link
Member Author

Wumpf commented Oct 4, 2023

only docs I noticed in need of updating is the note I made on lack of mtl support. Btw. on that the file used does specify a mtl file, so ignoring it silently works (should probably do a warning, but whatever, punting on this)

Otherwise, all our docs seem already to claim obj, gltf and glb support!

@Wumpf
Copy link
Member Author

Wumpf commented Oct 4, 2023

oh shoot. I didn't push that note yet, looks like I'm not very focused today 😳

@Wumpf
Copy link
Member Author

Wumpf commented Oct 4, 2023

wasm: 15.33 MiB -> 15.37 MiB

That's not nothing, but acceptable for now.

@Wumpf Wumpf merged commit 03f44a2 into main Oct 4, 2023
30 of 31 checks passed
@Wumpf Wumpf deleted the andreas/obj-mesh-support branch October 4, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unlike documented, Asset3D doesn't support obj files yet
2 participants