Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the python API docs site for the new APIs #3565

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Sep 29, 2023

What

Replaces the logging functions with the archetypes.
Moves the deprecated function to their own section.

Also fixes the color inversion issue.

Checklist

@jleibs jleibs marked this pull request as ready for review September 29, 2023 20:44
@jleibs jleibs added the 📖 documentation Improvements or additions to documentation label Sep 29, 2023
@jleibs jleibs changed the title Jleibs/updated mkdocs Update the python API docs site for the new APIs Sep 29, 2023
Base automatically changed from jleibs/deprecate_legacy_loggers to main September 30, 2023 08:06
@Wumpf Wumpf self-requested a review October 2, 2023 08:22
],
class_list=[],
func_list=[],
class_list=["Points2D", "Points3D", "Boxes2D", "Boxes3D", "LineStrips2D", "LineStrips3D", "Mesh3D", "Asset3D"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrow is missing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: what is this order? O.o

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordered by increasing complexity of object. Same as how the functions were ordered.

- [rerun.log][]: APIs for logging data
- [rerun.color_conversion][]: Conversion utilities related to colors
- [rerun.components][]: Helpers for constructing arrow components
- [rerun.archetypes][]: Common objects for logging primitives understood by the viewer, e.g. Points and Lines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [rerun.archetypes][]: Common objects for logging primitives understood by the viewer, e.g. Points and Lines.
- [rerun.archetypes][]: Common objects for logging tagged data understood by the viewer, e.g. Points and Lines.

maybe better? I'm getting more and more uneasy around "primitives". Putting tagged here might be too much though (also we never call the indicators 'tagged'), but maybe something like this

@abey79
Copy link
Member

abey79 commented Oct 2, 2023

The generated documentation structure is pretty badly broken for me. This is clicking Point2d from the "landing page":

image

Notice no title or anything for the class. Also note TOC on the right hand side.

On Safari, this is aggravated by layout issues:

image

@jleibs jleibs merged commit 23dd97b into main Oct 2, 2023
30 checks passed
@jleibs jleibs deleted the jleibs/updated_mkdocs branch October 2, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Python API docs landing page
4 participants