Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depth point cloud not taking transformation at its path into account #3514

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 28, 2023

What

Repro code:

import numpy as np
import rerun as rr

rr.init("depth_camera", spawn=True)

rr.log(
    "world0/rgbd_camera",
    rr.TranslationAndMat3x3(translation=[10.0, 0.0, 0.0], matrix=np.eye(3)),
)
rr.log_pinhole("world0/rgbd_camera/image", height=480, width=640, focal_length_px=500.0)
rr.log("world0/rgbd_camera/image/depth", rr.DepthImage(np.random.rand(480, 640)))


rr.log(
    "world1/rgbd_camera",
    rr.TranslationAndMat3x3(translation=[10.0, 0.0, 0.0], matrix=np.eye(3)),
)
rr.log_pinhole("world1/rgbd_camera", height=480, width=640, focal_length_px=500.0)
rr.log("world1/rgbd_camera/depth", rr.DepthImage(np.random.rand(480, 640)))


rr.log(
    "world2/rgbd_camera",
    rr.TranslationAndMat3x3(translation=[10.0, 0.0, 0.0], matrix=np.eye(3)),
)
rr.log_pinhole("world2/rgbd_camera", height=480, width=640, focal_length_px=500.0)
rr.log("world2/rgbd_camera", rr.DepthImage(np.random.rand(480, 640)))

Before:
Screenshot 2023-09-28 at 12 02 06

After:
image

Checklist

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Sep 28, 2023
@teh-cmc teh-cmc merged commit 8cd24b2 into main Sep 28, 2023
30 of 31 checks passed
@teh-cmc teh-cmc deleted the andreas/fix-depth-projection-transform branch September 28, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera extrinsics and intrinsics on same path does not work for depth images
2 participants