-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web-Viewer: Don't auto-connect to wss://hostname
when an ?url=
is missing
#3345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is 100% the right approach.
The fallback_to_websockets: bool
seems to me quite a hack, especially as it is controlled from JavaScript. It is, as far as I can tell, trying to subvert the fallback in get_url
for what URL to connect to. Do we need this fallback at all though? All the places where we open the web-viewer for the user we already add the ?url=…
query parameter for them.
For instance, cargo r -p raw_mesh -- --serve
will print this:
Listening for websocket traffic on ws://localhost:9877. Connect with a Rerun Web Viewer.
Started web server on http://localhost:9090
Web server is running - view it at http://localhost:9090?url=ws://localhost:9877
and then it opens that last URL.
I think it would make more sense to remove the fallback from get_url
and handle no URL by simply adding no receiver to the application. This will make the web-viewer without an url=
query act similar to just running rerun
, i.e. make it more similar to the native viewer
I removed the |
Should we also remove this dropdown in this PR then? The demo link in the PR description https://demo.rerun.io/pr/3345 does not show the welcome page |
That's because |
app
and demo
wss://hostname
when an ?url=
is missing
What
app.rerun.io
should show the welcome screen #3276app.rerun.io
should default to a blank viewer with the Welcome Screen #3196Checklist