Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create objects for delegating components #3303

Merged
merged 19 commits into from
Sep 13, 2023
Merged

Create objects for delegating components #3303

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f82e55d
Detect and inject _ext.py mixin
jleibs Sep 12, 2023
48d3683
Detect the relevant overrides from the extension class
jleibs Sep 12, 2023
4b2d6f8
Inject new-style converters
jleibs Sep 12, 2023
c9624fc
Support for native_to_pa_array override
jleibs Sep 12, 2023
c4164dc
Support for __init__ / __array__ and assorted cleanup
jleibs Sep 12, 2023
936beb1
Mypy being stupid
jleibs Sep 12, 2023
011347a
Update docs
jleibs Sep 12, 2023
099fa27
Migrate color and angle to new style
jleibs Sep 12, 2023
d9949af
codegen
jleibs Sep 12, 2023
0a434ef
A bit more in the docs
jleibs Sep 12, 2023
846c33e
Rename to ExtensionClass. Add more docs and docstrings
jleibs Sep 12, 2023
e2a870c
Spell
jleibs Sep 12, 2023
c60243e
Some comments aren't doctests
jleibs Sep 12, 2023
f34a2f0
Create Component objects, even for DelegatingComponents
jleibs Sep 12, 2023
db6375f
Migrate TextLogLevel to extension class
jleibs Sep 12, 2023
8b04331
Codegen for the other components
jleibs Sep 12, 2023
d3d8b18
Add pass for delegating component declaration
jleibs Sep 12, 2023
9adfe7d
Merge branch 'main' into jleibs/component_objects
jleibs Sep 13, 2023
177f583
Bad merge
jleibs Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/re_types/source_hash.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions crates/re_types_builder/src/codegen/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,15 @@ pub fn remove_old_files_from_folder(folder_path: Utf8PathBuf, filepaths: &BTreeS
continue;
}

if let Some(stem) = filepath.as_str().strip_suffix("_ext.py") {
let generated_path = Utf8PathBuf::try_from(format!("{stem}.py")).unwrap();
assert!(
generated_path.exists(),
"Found orphaned {filepath} with no matching {generated_path}"
);
continue;
}

if let Some(stem) = filepath.as_str().strip_suffix("_ext.cpp") {
let generated_hpp_path = Utf8PathBuf::try_from(format!("{stem}.hpp")).unwrap();
assert!(
Expand Down
Loading