Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve viewport tile behavior #3295

Merged
merged 9 commits into from
Sep 13, 2023
Merged

Improve viewport tile behavior #3295

merged 9 commits into from
Sep 13, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Sep 12, 2023 •
edited
Loading

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface dependencies concerning crates, pip packages etc labels Sep 12, 2023
@Wumpf Wumpf self-requested a review September 13, 2023 06:41
Wumpf
Wumpf approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scrolled over the egui_tiles pr and played around with the result in the browser, looks good to me

crates/re_renderer/src/allocator/gpu_readback_belt.rs
@@ -348,7 +348,7 @@ impl GpuReadbackBelt {
self.received_chunks = retained;

for chunk in discarded {
re_log::debug!(
re_log::trace!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that one was starting to annoy me as well

@emilk emilk merged commit 4c9753e into main Sep 13, 2023
@emilk emilk deleted the emilk/fix-weird-tiles-behavior branch September 13, 2023 07:29
@emilk emilk mentioned this pull request Sep 25, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working dependencies concerning crates, pip packages etc ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
2 participants
@emilk @Wumpf