Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on garbage-collection (--memory-limit) by default #3161

Merged
merged 11 commits into from
Aug 31, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 30, 2023

What

This sets the default --memory-limit to 75%, meaning rerun will by default start dropping old data when rerun is using 75% of the total system RAM.

This simplifies the use of Rerun a lot - just pipe data to it, and it won't crash.

Checklist

@emilk emilk changed the title Emilk/always on memory limit Turn on garbage-collection (--memory-limit) by default. Aug 30, 2023
@emilk emilk changed the title Turn on garbage-collection (--memory-limit) by default. Turn on garbage-collection (--memory-limit) by default Aug 30, 2023
@emilk emilk added 📺 re_viewer affects re_viewer itself 🚀 performance Optimization, memory use, etc labels Aug 31, 2023
@emilk emilk merged commit 89d12df into main Aug 31, 2023
@emilk emilk deleted the emilk/always-on-memory-limit branch August 31, 2023 13:44
@nikolausWest
Copy link
Member

The related how-to article also needs to be updated

@emilk
Copy link
Member Author

emilk commented Sep 5, 2023

The related how-to article also needs to be updated

I did: https://github.com/rerun-io/rerun/pull/3161/files#diff-a55e1994efe2fa6e2342ab47d217bc9359f7d3023a03bb547725b11159d3a84c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 performance Optimization, memory use, etc 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Garbage collection should be on by default
3 participants