Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ehttp in re_analytics #3155

Merged
merged 15 commits into from
Aug 30, 2023
Merged

Use ehttp in re_analytics #3155

merged 15 commits into from
Aug 30, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Aug 30, 2023 •
edited by github-actions bot
Loading

What

Closes #3104
Part of #2966

  • Replaces all usages of ureq in re_analytics with ehttp. Because ehttp uses a "push" model for its fetch API (you receive the Result via a callback), the error handling in re_analytics had to be adapted.
  • Adds and uses AbortSignal to abort the analytics pipeline on the first error.
  • Silences rustls in release mode

This PR does not enable web analytics in any way, that's still blocked on tel.rerun.io having CORS setup properly.

Checklist

@jprochazk jprochazk added 📺 re_viewer affects re_viewer itself 📊 analytics telemetry analytics labels Aug 30, 2023
@jprochazk jprochazk mentioned this pull request Aug 30, 2023
Closed
7 tasks
emilk
emilk approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

crates/re_analytics/src/native/mod.rs Outdated Show resolved Hide resolved
crates/re_analytics/src/native/pipeline.rs Outdated Show resolved Hide resolved
crates/re_log/src/lib.rs Show resolved Hide resolved
@jprochazk jprochazk merged commit e7b56ae into main Aug 30, 2023
@jprochazk jprochazk deleted the jan/analytics-ehttp branch August 30, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
📊 analytics telemetry analytics 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce log-spam from analytics cert issues
2 participants
@jprochazk @emilk