Support loading images and meshes on web #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🕸️ web
emilk
commented
Aug 28, 2023
| re_log_types::DataTable::from_rows(re_log_types::TableId::random(), [data_row]); | ||
| let arrow_msg = data_table.to_arrow_msg()?; | ||
| Ok(LogMsg::ArrowMsg(store_id, arrow_msg)) | ||
| } |
There was a problem hiding this comment.
Creating log messages is quite verbose 😬
There was a problem hiding this comment.
At least it doesn't look too arcane.
emilk
commented
Aug 28, 2023
| @@ -329,7 +329,7 @@ impl App { | |||
| self.add_receiver(rx); | |||
| } | |||
| Err(err) => { | |||
| re_log::error!("Failed to open data source: {err}"); | |||
| re_log::error!("Failed to open data source: {}", re_error::format(err)); | |||
There was a problem hiding this comment.
This is a really bad gotcha. By default, anyhow::Error only shows the latest part of its context 🤦
abey79
approved these changes
Aug 29, 2023
| re_log_types::DataTable::from_rows(re_log_types::TableId::random(), [data_row]); | ||
| let arrow_msg = data_table.to_arrow_msg()?; | ||
| Ok(LogMsg::ArrowMsg(store_id, arrow_msg)) | ||
| } |
There was a problem hiding this comment.
At least it doesn't look too arcane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Drag-dropping images and meshes now works on web, as does File->Open.
I also managed to get rid of the use of
MsgSenderto create aLogMsg, simplifying the dependencies a bit (if not the code).Checklist