Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize big point clouds by ~20% #3108

Merged
merged 11 commits into from
Aug 25, 2023
Merged

Optimize big point clouds by ~20% #3108

merged 11 commits into from
Aug 25, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 25, 2023 •
edited by github-actions bot
Loading

What

Add more profile scopes. Use slices instead of iterators.

cargo rerun ../opf.rrd --profile, looking at only 3D view.

Full frame goes from 79ms -> 63ms = 20% faster.

Before:
image

After:
image

Checklist

@emilk emilk added 📺 re_viewer affects re_viewer itself 🚀 performance Optimization, memory use, etc labels Aug 25, 2023
@emilk emilk marked this pull request as ready for review August 25, 2023 12:50
@emilk emilk changed the title Optimize point clouds Optimize big point clouds by ~20% Aug 25, 2023
@emilk emilk merged commit effb72b into main Aug 25, 2023
@emilk emilk deleted the emilk/points-profile-scopes branch August 25, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf left review comments

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
🚀 performance Optimization, memory use, etc 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilk @Wumpf @teh-cmc