Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform icon, pointer, and tooltip for external links #3026

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Uniform icon, pointer, and tooltip for external links #3026

merged 1 commit into from
Aug 18, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Aug 17, 2023 •
edited
Loading

What

This PR unifies the behaviour of our external links (welcome screen, help menu item, top rerun.io logo), which should include:

  • pointy finger mouse pointer
  • external link icon (rerun.io logo is an exception here—it'll be redesigned soon-ish anyway)
  • url in tooltip
image

cc @martenbjork

Checklist

@abey79 abey79 added the ui concerns graphical user interface label Aug 17, 2023
@abey79 abey79 requested a review from emilk August 17, 2023 12:58
@abey79 abey79 mentioned this pull request Aug 17, 2023
Merged
3 tasks
@emilk emilk merged commit a01dd58 into main Aug 18, 2023
@emilk emilk deleted the antoine/unified-link-behaviour branch August 18, 2023 06:40
@martenbjork martenbjork mentioned this pull request Aug 21, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abey79 @emilk