Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure re_analytics never log higher than at debug level #3014

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Make sure re_analytics never log higher than at debug level #3014

merged 1 commit into from
Aug 17, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 17, 2023 •
edited by github-actions bot
Loading

Checklist

@emilk emilk added the 📊 analytics telemetry analytics label Aug 17, 2023
@emilk emilk added this to the 0.8.1 milestone Aug 17, 2023
@Wumpf Wumpf self-requested a review August 17, 2023 09:52
Wumpf
Wumpf approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. any chance we can test the situation that caused the log spam to be sure this works?

@emilk
Copy link
Member Author

emilk commented Aug 17, 2023

Easy reproduce is disconnecting from the internet and running RUST_LOG=debug cargo rerun which now prints

[2023-08-17T10:12:13Z DEBUG re_analytics::pipeline_native] Failed to send analytics down the sink, will try again later.
    HTTP transport: http://tel.rerun.io/: Dns Failed: resolve dns name 'tel.rerun.io:80': failed to lookup address information: nodename nor servname provided, or not known
                
[2023-08-17T10:12:13Z DEBUG re_analytics::pipeline_native] couldn't flush analytics data file: HTTP transport: http://tel.rerun.io/: Dns Failed: resolve dns name 'tel.rerun.io:80': failed to lookup address information: nodename nor servname provided, or not known

The first message there used to be a warning (thus visible as a popup in the viewer).

This is only one message though, no spamming. I'm not sure if that was what the customer reported (the issue is quite sparse on detail).

@emilk emilk merged commit d023720 into main Aug 17, 2023
@emilk emilk deleted the emilk/lower-analytics-log-levels branch August 17, 2023 10:14
emilk added a commit that referenced this pull request Aug 17, 2023
@emilk
Make sure re_analytics never log higher than at debug level (#3014)
0a37a25 
* Closes #3012

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3014) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3014)
- [Docs
preview](https://rerun.io/preview/pr%3Aemilk%2Flower-analytics-log-levels/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aemilk%2Flower-analytics-log-levels/examples)
@emilk emilk mentioned this pull request Aug 17, 2023
Closed
3 tasks
emilk added a commit that referenced this pull request Aug 17, 2023
@emilk
Make sure re_analytics never log higher than at debug level (#3014)
771d2de 
* Closes #3012

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3014) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3014)
- [Docs
preview](https://rerun.io/preview/pr%3Aemilk%2Flower-analytics-log-levels/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aemilk%2Flower-analytics-log-levels/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
📊 analytics telemetry analytics
Projects
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.

Error logs from analytics spam terminal when anonymous analytics fails
2 participants
@emilk @Wumpf