Fix unable to set camera spinning until camera has moved #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
reviewed
Aug 15, 2023
|
|
||
| pub fn set_spin(&mut self, spin: bool) { | ||
| self.spin = spin; | ||
| self.did_interact_with_eye = true; |
There was a problem hiding this comment.
Just noting: as soon as we click spin, we'll lose the "zoom out to fit" behavior. I think this is a good compromise for now and a strict improvement as implemented, but it would be pretty neat if we could manage to get a behavior where it spins but also continues to zoom out as new data arrives.
There was a problem hiding this comment.
hmm yeah I suppose the "zoom to thing" method could also be made working with spin on. But let's leave this for another time!
jleibs
approved these changes
Aug 15, 2023
emilk
pushed a commit
that referenced
this pull request
Aug 17, 2023
Fixes #2892 Thought this was related to blueprint system overwriting, but it was something else entirely actually: The "interpolate to"-method would set spin to false and we would interpolate to whatever the latest default position of the camera is until it is moved first. * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2990) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2990) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-non-sticky-spinbox/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-non-sticky-spinbox/examples)
emilk
pushed a commit
that referenced
this pull request
Aug 17, 2023
Fixes #2892 Thought this was related to blueprint system overwriting, but it was something else entirely actually: The "interpolate to"-method would set spin to false and we would interpolate to whatever the latest default position of the camera is until it is moved first. * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2990) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2990) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-non-sticky-spinbox/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-non-sticky-spinbox/examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2892
Thought this was related to blueprint system overwriting, but it was something else entirely actually: The "interpolate to"-method would set spin to false and we would interpolate to whatever the latest default position of the camera is until it is moved first.
Checklist