Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't select the spaceview when maximizing it #2988

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 15, 2023

Closes #2861

Checklist

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the (trivial) change looks good. But how did codegen sneak in here :O

@emilk emilk force-pushed the emilk/dont-select-on-maximize branch from 9eef65e to 714fd1c Compare August 16, 2023 11:00
@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself labels Aug 16, 2023
@emilk emilk requested a review from Wumpf August 16, 2023 11:00
@emilk emilk enabled auto-merge (squash) August 16, 2023 11:19
@emilk emilk merged commit 1344e2a into main Aug 16, 2023
@emilk emilk deleted the emilk/dont-select-on-maximize branch August 16, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximizing a view in the viewport shouldn't automatically select it
2 participants