-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to wgpu 0.17 & latest egui #2980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very glad to have this! I'm hardly able to comment about the code, but I made a note of my new favourite egui commit :)
Depends on emilk/egui#3260 now |
Last commit fixes a Chrome only bug that Naga doesn't catch yet, see gfx-rs/naga#2439 |
(note that this fix was unrelated to the update here; this is rather keeping up with Chrome / the spec) |
ignoring failed pr body update ci |
What
shared_paint_callback_resources
to storeViewBuilder
, but it can't be accessed without a handle to the eframe renderer.The end goal would be to get rid of re_renderer's
per_frame_data_helper
. This will likely be enabled with wgpu's "Arcanization" effort as this will eliminatewgpu::RenderPass
's lifetime dependency. In that case we could store aMutex<ViewBuilder>
onReRendererCallback
🤔fragile-send-sync-non-atomic-wasm
on wgpu (luckily egui itself no longer has this restriction). The problem is that a lot of our infrastructure is built around assumingSend
/Sync
whereas in actuality webgpu rendering resources can't be shared accross threads easily.Checklist