Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hierarchical display in recordings panel #2971

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Add hierarchical display in recordings panel #2971

merged 5 commits into from
Aug 14, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Aug 13, 2023 •
edited
Loading

What

This PR updates the recording UI to display recording hierarchically when multiple recordings for the same app ID are loaded. If a single recording for a given app ID is loaded, a single line is still used for compactness.

This PR also improves the egui::Id handling for ListItem::show_collapsing().

TODO:

  • sort out vertical spacing
image

Checklist

@abey79
Add hierarchical display for multiple recordings with same app ID
abdaecd 
+ better handling of ID for collapsing ListItem
@abey79 abey79 added the ui concerns graphical user interface label Aug 13, 2023
@emilk emilk self-requested a review August 14, 2023 07:20
emilk
emilk approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

crates/re_viewer/Cargo.toml Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/recordings_panel.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/recordings_panel.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/recordings_panel.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/recordings_panel.rs Outdated Show resolved Hide resolved
@abey79
Copy link
Member Author

abey79 commented Aug 14, 2023

Works great!

Thanks. Love those nits around Option, etc.—I need to improve at that.

@abey79 abey79 merged commit 4f23c15 into main Aug 14, 2023
@abey79 abey79 deleted the antoine/recordings-hierarchy branch August 14, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abey79 @emilk