Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update egui via a [patch] #2969

Merged
merged 7 commits into from
Aug 14, 2023
Merged

Update egui via a [patch] #2969

merged 7 commits into from
Aug 14, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Aug 12, 2023 •
edited
Loading

What

Patch egui to master. This brings wgpu to 0.17 and addresses emilk/egui#3176 🚀

Checklist

@abey79 abey79 added 🧑‍💻 dev experience developer experience (excluding CI) dependencies concerning crates, pip packages etc labels Aug 12, 2023
emilk
emilk reviewed Aug 12, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you roll back the egui commits to before the wgpu update and we'll update wgpu in a separate PR

@abey79 abey79 merged commit 4c20e4b into main Aug 14, 2023
@abey79 abey79 deleted the antoine/egui-update branch August 14, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc 🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abey79 @emilk