-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize point cloud rendering #2950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit worrisome that reading from the store is that slow. Feels a bit more like a workaround for store reads that shouldn't be that slow?
Yeah, it is pretty crazy that it is this slow |
I added a reminder in #2523 to revert this when we have optimized the store |
Let's hold off merging this until we take a proper stab at #2523 - iterating through a bunch |
Let's give it another spin on top of #2970 |
Will do |
What
Makes
open_photogrammetry_format
example ~30% faster by only callingiter_required_component::<Point3D>()
once per frame instead of twice.Before: 158 ms/frame:
After: 119 ms/frame:
(debug builds)
This is a bit of a stop-gap until #2523 is fixed
Checklist