-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ codegen extensions, archetype tests, array ctors #2916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
commented
Aug 5, 2023
Wumpf
commented
Aug 7, 2023
Wumpf
commented
Aug 7, 2023
Closed
teh-cmc
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤌
Wumpf
force-pushed
the
andreas/cpp/custom-extensions
branch
from
August 7, 2023 08:22
fa1b387
to
e73a7cb
Compare
emilk
added
examples
Issues relating to the Rerun examples
exclude from changelog
PRs with this won't show up in CHANGELOG.md
and removed
examples
Issues relating to the Rerun examples
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Introduces a simple extension system for C++ codegen: Add an extra cpp file that will be compiled as part of the SDK. A section between two markes is copied into the generated hpp as part of generation (typically this section is removed from compilation via #ifdef)
Adds extensions to:
... and uses them to simplify examples and test code!
All fully supported archetypes now have a simple test that checks that the base interface works and that we can serialize out to arrow without issues.
Additionally, there's tests for vecN/quaternion/color to check that their various constructors work as expected (not being a C++ expert it's fairly hard to predict)
Extends codegen with single-array-field-constructors.
Arrow3D
migration to archetypes #2785Point{2|3}D
migration to archetypes #2789Transform3D
+DisconnectedTransform
migration to archetypes #2791Checklist