Normalize various text string in UI #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martenbjork
suggested changes
Aug 3, 2023
Well spotted 👍🏻 I actually found a bunch more to fix along the way. I fully expect that there are more lurking 😅 |
martenbjork
reviewed
Aug 4, 2023
martenbjork
reviewed
Aug 4, 2023
martenbjork
reviewed
Aug 4, 2023
martenbjork
reviewed
Aug 4, 2023
martenbjork
approved these changes
Aug 4, 2023
# Conflicts: # crates/re_types/source_hash.txt
emilk
reviewed
Aug 7, 2023
| ui.label(tensor.dtype().to_string()); | ||
| ui.end_row(); | ||
|
|
||
| re_ui | ||
| .grid_left_hand_label(ui, "Shape") | ||
| .on_hover_text("Extent of every dimension."); | ||
| .on_hover_text("Extent of every dimension"); |
There was a problem hiding this comment.
we should add a lint for this in scripts/lint.py!
There was a problem hiding this comment.
I agree, but I got lazy because linting rust with regex is rather annoying. How do you feel about putting in place some (syn-based?) rust-based rust lint?
emilk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Normalises various text strings as per #2724. The writing rules are now made explicit in
design/writing_rules.md.Fixes #2724
Checklist