Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle older numpy versions / py 3.8 in VecND extensions #2896

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Aug 2, 2023

What the title says.

This is what prevented us from doing the logical thing in Arrow3D extensions (and became even more of an issue after I made the PointND components use VecND internally in #2894).

What

Checklist

@teh-cmc teh-cmc requested a review from abey79 August 2, 2023 14:29
@teh-cmc teh-cmc added 🪳 bug Something isn't working 🐍 Python API Python logging API labels Aug 2, 2023
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻 Annoying to have to do this—I won't be missing 3.8 when we drop it...

@teh-cmc teh-cmc merged commit 98701e0 into main Aug 2, 2023
@teh-cmc teh-cmc deleted the cmc/fix_vecnd_vs_numpy branch August 2, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants