Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove expansion effect from time panel toolbar #2863

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Remove expansion effect from time panel toolbar #2863

merged 1 commit into from
Jul 28, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jul 28, 2023 •
edited
Loading

What

Remove expansion effect from the time panel buttons and adjust hover area of nearby controls to keep everything aligned.

Fixes #2730

Before:

image image

After:

image image

Checklist

@abey79 abey79 requested a review from martenbjork July 28, 2023 09:29
@abey79 abey79 added the ui concerns graphical user interface label Jul 28, 2023
martenbjork
martenbjork approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@martenbjork martenbjork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chefs_kiss: 🔥

Wumpf
Wumpf approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
code looks good. ui behaves as expected on demo.rerun.io before/after

@abey79 abey79 merged commit 51058eb into main Jul 28, 2023
@abey79 abey79 deleted the antoine/no-expansion-time-panel branch July 28, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

@martenbjork martenbjork martenbjork approved these changes

Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove scaling effect when hovering buttons
3 participants
@abey79 @martenbjork @Wumpf