[re_renderer] Enable 4x MSAA #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: seems webgl ignores alpha to coverage and then everything looks just a little it worse than before (because we're hitting the edges of the squares essentially as we don't discard when we should) |
|
was a matter of fixing it in wgpu as well gfx-rs/wgpu#3187 |
also better document the various color conversions and formats
emilk
approved these changes
Nov 8, 2022
| // TODO(andreas): Do something meaningful with values above 1 | ||
| let hdr = clamp(hdr, vec3<f32>(0.0), vec3<f32>(1.0)); | ||
| return Vec4(srgb_from_linear(hdr), 1.0); | ||
| let input = clamp(input, vec3<f32>(0.0), vec3<f32>(1.0)); |
There was a problem hiding this comment.
Suggested change
| let input = clamp(input, vec3<f32>(0.0), vec3<f32>(1.0)); | |
| let input = clamp(input, Vec3(0.0), Vec3(1.0)); |
There was a problem hiding this comment.
doesn't work gfx-rs/naga#2105
tbh I'm not so sure about our typedefs
There was a problem hiding this comment.
Dare I even say:
Suggested change
| let input = clamp(input, vec3<f32>(0.0), vec3<f32>(1.0)); | |
| let input = clamp(input, ZERO, ONE); |
👀
| var modified_radius = point_data.radius * distance_to_camera_inv * sqrt(distance_to_camera_sq - radius_sq); | ||
| // We're computing a coverage mask int the fragment shader - make sure the quad doesn't cut off our antialiasing. | ||
| // It's fairly subtle but if we don't do this our spheres look slightly squarish | ||
| modified_radius += frame.pixel_world_size_from_camera_distance / distance_to_camera_inv; |
There was a problem hiding this comment.
... I love Iq's work, but took me ages to understand his sphere AA shadertoy and then a bit more to understand "custom" pieces like this one :)
Wumpf
force-pushed
the
andreas/re_renderer/msaa
branch
from
5251c9e
to
6299bf4
Compare
|
Fixes PRO-244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables 4x MSAA and alpha to coverage for point cloud.
left new with MSAA, right old no MSAA
For the latter it took me quite a while to disect what Iq is doing here, but I think I was able to grasp it and put my knowledge into comments and overly long variable names.
left new with alpha to coverage, right old no MSAA
Two wgpu PRs came out of this work regarding webgl compatibility.
The Alpha to coverage one has landed and the float MSAA one is no longer required as I disabled HDR rendering for the time being (thanks @emilk for pointing out that we don't actually need it yet). There's comments about that in the code.
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)