Add support for .gitignore to scripts/lint.py

.github/workflows/reusable_checks.yml

@@ -282,6 +282,10 @@ jobs:
         with:
           python-version: "3.8"
 
+      - name: Install dependencies
+        run: |
+          pip install gitignore_parser
+
       - name: Rerun lints
         run: |
           ./scripts/lint.py
@@ -325,4 +329,3 @@ jobs:
         shell: bash
         id: expected_version
         run: ./scripts/ci/cargo_deny.sh
-

scripts/lint.py

@@ -13,6 +13,8 @@
 import sys
 from typing import Any
 
+from gitignore_parser import parse_gitignore
+
 # -----------------------------------------------------------------------------
 
 todo_pattern = re.compile(r"TODO([^(]|$)")
@@ -443,8 +445,6 @@ def main() -> None:
 
         extensions = ["c", "cpp", "fbs", "h", "hpp" "html", "js", "md", "py", "rs", "sh", "toml", "txt", "wgsl", "yml"]
 
-        exclude_dirs = {"env", "renv", "venv", "venv3.10", "target", "target_ra", "target_wasm", ".nox"}
-
         exclude_paths = {
             "./CODE_STYLE.md",
             "./crates/re_types_builder/src/reflection.rs",  # auto-generated
@@ -454,12 +454,17 @@ def main() -> None:
             "./web_viewer/re_viewer_debug.js",  # auto-generated by wasm_bindgen
         }
 
+        matches = parse_gitignore(".gitignore")
+
         for root, dirs, files in os.walk(".", topdown=True):
-            dirs[:] = [d for d in dirs if d not in exclude_dirs]
+            dirs[:] = [d for d in dirs if not matches(d)]
+
             for filename in files:
                 extension = filename.split(".")[-1]
                 if extension in extensions:
                     filepath = os.path.join(root, filename)
+                    if matches(filepath):
+                        continue
                     if filepath not in exclude_paths:
                         num_errors += lint_file(filepath, args)
 

scripts/requirements-dev.txt

@@ -10,3 +10,4 @@ PyGithub==1.58.2 # for scripts/ci/generate_pr_summary.py and scripts/ci/update_p
 Pillow # for scripts/upload_image.py
 tqdm
 requests
+gitignore_parser  # handle .gitignore