-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python backport: add log_any()
#2581
Changes from 9 commits
01c672a
8081ab9
869456a
57912e8
e11aca7
3318567
3b58d94
4b5f2ed
6e1e2b8
3da7eff
cd7e05f
e448c28
3933fba
129719a
7107760
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# This is a sha256 hash for all direct and indirect dependencies of this crate's build script. | ||
# It can be safely removed at anytime to force the build script to run again. | ||
# Check out build.rs to see how it's computed. | ||
128cd542f3f9e6cf3b2a44aeb022cd5f3ad819b00ce5371eeb311300f3e9a7f1 | ||
b7927e46605c38a4659f7c90a026f6ce5903e84428414549725107993a4af38a |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,8 @@ | |
|
||
from __future__ import annotations | ||
|
||
__all__ = ["AffixFuzzer1", "Points2D"] | ||
__all__ = ["Archetype", "AffixFuzzer1", "Points2D"] | ||
|
||
from ._base import Archetype | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not a big fan of having the abstract super class (or whatever it's called) be defined in this package with the rest of the actual archetypes... Can we put those abstract classes at the very top maybe? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moving them all to Note that in the next PR:
|
||
from .fuzzy import AffixFuzzer1 | ||
from .points2d import Points2D |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
from __future__ import annotations | ||
|
||
from dataclasses import dataclass | ||
|
||
|
||
@dataclass | ||
class Archetype: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this means that this example only runs with
_ENABLE_NEXT_GEN_API
now right?How about we do something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I'll make that variable public then (remove the leading
_
).