Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal example of running an intel realsense depth sensor live #2541
Minimal example of running an intel realsense depth sensor live #2541
Changes from 4 commits
46ed2fd
f7a291b
eb028b0
afb479d
9cc8b35
17ca68b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the transform is
rgb_from_depth
, so doesn't it make sense if the parent is called "depth" and the child "color"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of if you strictly follow the API. But that's problematic because "depth" is on the far side of a pinhole transform so we can't use that.
I could log as something like
But I don't really find that nesting one camera inside the other adds much clarity.
From a driver perspective, neither camera is really "under" the other. Practically speaking they're siblings, but the driver doesn't expose an API to an abstract origin. We could have just as easily called the reverse API though (
rgb_profile.get_extrinsics_to(depth_profile)
). I think of this as saying that we (arbitrarilly) define the origin of the realsense space to be the same as the child (depth).I don't love having "camera/ext" in there though either way so will add some comments and clean up.