Space view scenes (parts) are now independent of space view type #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
1 task
Wumpf
changed the title
1 task
Wumpf
added a commit
that referenced
this pull request
Jun 29, 2023
<!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What Noticed while testing: Removed text entity filter ui; this was already defunct on main and is redundant to entity visibility property. Was originally part of #2522 Test via `python ./examples/python/text_logging/main.py` ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2544 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/8e1e06b/docs Examples preview: https://rerun.io/preview/8e1e06b/examples <!-- pr-link-docs:end -->
Wumpf
force-pushed
the
andreas/space-view-class-independent-scenes
branch
from
bdac16b
to
c6ec303
Compare
emilk
pushed a commit
that referenced
this pull request
Jun 29, 2023
<!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What Noticed while testing: Removed text entity filter ui; this was already defunct on main and is redundant to entity visibility property. Was originally part of #2522 Test via `python ./examples/python/text_logging/main.py` ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2544 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/8e1e06b/docs Examples preview: https://rerun.io/preview/8e1e06b/examples <!-- pr-link-docs:end -->
This was referenced Jul 10, 2023
Wumpf
added a commit
that referenced
this pull request
Jul 12, 2023
As discussed in todays call and detailed in https://github.com/rerun-io/rerun/blob/andreas/space_views-rfc/design/space_views.md#viewpartsystem (WIP rfc) There's a whole bunch of consecutive renames arising from that, none of which I brought up since they are much lower stakes: They all revolve around the idea that "scene" doesn't make sense for the temporary datastructure we build up every frame. That said, it is still around for the moment and will be likely removed or renamed as well very soon. Similarly, there's some follow-up to do in the docs (and the aforementioned rfc document) Obsoletes #2522 since it causes too many conflicts there - will reimplement key ideas from that PR though, seeing a bit clearer by now where we want to end up. This 100% pure refactoring, no logic has been touched, only renaming and moving things around. Renames: * ScenePart -> ViewPartSystem * SceneContextPart -> ViewContextSystem * ScenePartCollection -> ViewPartSystemCollection * SceneContext -> ViewContext (todo: weird discrepancy to system collection) * SceneQuery -> ViewQuery * derived types, mostly in SpatialSpaceView crate * related type fields * related argument names * file renamings, flattening out of `scene` folder for `SpatialSpaceView` ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2674) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2674) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Fviewpartsystem-rename/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Fviewpartsystem-rename/examples)
3 tasks
|
Superseeded by #2688 |
Wumpf
added a commit
that referenced
this pull request
Jul 14, 2023
(Replaces #2522) Part of * #2649 For in-depth overview of how space views work now see #2533 Replaces custom user types for context and parts with typemap style collections. These are filled every frame from a set of registered parts & contexts. Registration happens on the `SpaceViewRegistry` where we already register space view classes themselves. Other rippling changes in overview: * space view parts and context no longer have access to the space view's state struct, this fully decouples them from any concrete space view * space view part's data object is no longer strongly typed, but an `&Any` instead, fullfills otherwise the same purpose * `Scene`/`TypedScene` is gone now * most of what was previously the scene buildup is now part of `SpaceViewClass::ui` For reviewing it's recommended to start with everything in the `re_viewer_context` crate. Overview of major trait entry points - see also #2533 <img width="1120" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/ffdb1cdf-7efe-47a0-ac38-30262d770e69"> ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2688) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2688) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Fregistered-space-view-systems/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Fregistered-space-view-systems/examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. but space view types are ofc still dependent on the parts collection.
Things happening here:
SpaceViewStateto population ofSceneContextandScenePartsSpaceViewClassno longer specifies theSceneContextandScenePartData- this is now done by theScenePartCollectioninsteadThe first two changes allow us to use the same scene(part collection) for several space views, as it is needed by 2D & 3D space views which are right now the same type (but we want different types).
Checklist
PR Build Summary: https://build.rerun.io/pr/2522
Docs preview: https://rerun.io/preview/f25972d/docs
Examples preview: https://rerun.io/preview/f25972d/examples