Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freestanding store helpers coming back from the dead #2378

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jun 12, 2023

Not sure what happened there

@teh-cmc teh-cmc added the ⛃ re_datastore affects the datastore itself label Jun 12, 2023
@Wumpf Wumpf self-requested a review June 12, 2023 09:03
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also recently had a case of deleted files showing up again. At some point someone must have a bad merge resolution

@teh-cmc teh-cmc merged commit bdae196 into main Jun 12, 2023
@teh-cmc teh-cmc deleted the cmc/store_helpers_shenanigans branch June 12, 2023 09:22
@emilk
Copy link
Member

emilk commented Jun 12, 2023

This broke all interaction with 2D and 3D space views. Will revert.

@emilk
Copy link
Member

emilk commented Jun 12, 2023

The brokenness will reportedly be fixed by #2396

@emilk emilk added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ⛃ re_datastore affects the datastore itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants