Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale SpaceViewState struct from re_viewport #2352

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 9, 2023

What

Followup to #2334: Remove old SpaceViewState struct from re_viewport now that all space view states have the same trait type

Checklist

PR Build Summary: https://build.rerun.io/pr/2352

Docs preview: https://rerun.io/preview/b468b7a/docs
Examples preview: https://rerun.io/preview/b468b7a/examples

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality labels Jun 9, 2023
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Wumpf Wumpf merged commit c482cac into main Jun 9, 2023
@Wumpf Wumpf deleted the andreas/remove-old-spaceview-state branch June 9, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants